[Webkit-unassigned] [Bug 28327] Media layout tests should have a way to provide test files in different formats

Fri Sep 18 10:50:48 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=28327

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39732|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #52 from Eric Carlson <eric.carlson at apple.com>  2009-09-18 10:50:47 PDT ---
(From update of attachment 39732)
> +++ b/LayoutTests/ChangeLog

> +        * media/progress-event-total-expected.txt: Ditto

The only change to the expected results is to include the new event.total
value.

> +        * media/progress-event-total.html: Ditto

Accomodates new file duration as well as switching to findMediaFile().

> +++ b/LayoutTests/media/event-attributes.html

>  
>      <body onload="start()">
>  
> -        <video controls src="content/test.mp4" 
> +        <video controls
>              onabort="eventHandler()"
>              oncanplay="eventHandler()"
>              oncanplaythrough="eventHandler()"
> @@ -97,5 +99,9 @@
>              >
>          </video>
>  
> +        <script>
> +            setSrcByTagName("video", findMediaFile("video", "content/test"));
> +        </script>

Again, I would really prefer to have this done in the (existing) body load
event handler
instead of adding another script element.

r=me with these minor fixes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.