[Webkit-unassigned] [Bug 29292] [HTML5][Forms] Support for <textarea maxlength=N>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29292


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39745|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2009-09-18 09:48:00 PDT ---
(From update of attachment 39745)
> +    if (isEmpty())
> +        return 0;

This special case for empty and null strings is not needed.

> +    TextBreakIterator* it = characterBreakIterator(characters(), length());
> +    if (!it)
> +        return 0;

This is not new code, but it's really non-useful to return 0 here. It would be
way better to just return length().

> +    if (isEmpty())
> +        return 0;

This special case for empty and null strings is not needed.

> +    TextBreakIterator* it = characterBreakIterator(characters(), length());
> +    if (!it)
> +        return 0;

This is not new code, but it's really non-useful to return 0 here. It would be
better to return min(length(), numGraphemeClusters).

r=me as-is, though

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.