[Webkit-unassigned] [Bug 29354] RVCT compile error in LiteralParser.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29354


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39739|review?                     |review-
               Flag|                            |




--- Comment #3 from Oliver Hunt <oliver at apple.com>  2009-09-17 18:00:59 PDT ---
(From update of attachment 39739)
A significant part of me wants to just reject this patch on the grounds that
you really need to update your compiler -- for instance we basically don't
accept patches to support gcc3 for instance.

That said, in its current form there's no question of accepting this patch as
it basically results in two copies of the same code, and adds a platform ifdef
to code that has no reason to have any ifdefs.  If we must use a macro then we
should just replace the function with a macro, not maintain both a macro and
function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.