[Webkit-unassigned] [Bug 29354] New: RVCT compile error in LiteralParser.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29354

           Summary: RVCT compile error in LiteralParser.cpp
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kwangyul.seo at gmail.com


RVCT emits erros in compiling LiteralParser.cpp: 

"..\JavaScriptCore\runtime\LiteralParser.cpp", line 140: Error:  #304: no
instance of function template "JSC::isSafeStringCharacter" matches the argument
list
            argument types are: (const UChar)
          while (m_ptr < m_end && isSafeStringCharacter<mode>(*m_ptr))
                                  ^
          detected during instantiation of "JSC::LiteralParser::TokenType
JSC::LiteralParser::Lexer::lexString<parserMode>(JSC::LiteralParser::Lexer::LiteralParserToken
&) [with parserMode=JSC::LiteralParser::StrictJSON]" at line 85
"..\JavaScriptCore\runtime\LiteralParser.cpp", line 140: Error:  #304: no
instance of function template "JSC::isSafeStringCharacter" matches the argument
list
            argument types are: (const UChar)
          while (m_ptr < m_end && isSafeStringCharacter<mode>(*m_ptr))
                                  ^
          detected during instantiation of "JSC::LiteralParser::TokenType
JSC::LiteralParser::Lexer::lexString<parserMode>(JSC::LiteralParser::Lexer::LiteralParserToken
&) [with parserMode=JSC::LiteralParser::NonStrictJSON]" at line 86


I am not sure what happens here. RVCT just can't find the instance of
isSafeStringCharacter with the argumenmt type const UCHAR.

After I change isSafeStringCharacter to a macro, the problem is fixed.

#if COMPILER(RVCT)
#define isSafeStringCharacter(mode, c) \
    (((c) >= ' ' && (mode == LiteralParser::StrictJSON || (c) <= 0xff) && (c)
!= '\\' && (c) != '"') || (c) == '\t')
#else

...

#if COMPILER(RVCT)
        while (m_ptr < m_end && isSafeStringCharacter(mode, *m_ptr))
#else

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.