[Webkit-unassigned] [Bug 28327] Media layout tests should have a way to provide test files in different formats

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 17 15:50:18 PDT 2009


Hin-Chung Lam <hclam at google.com> changed:

           What    |Removed                     |Added
         Resolution|FIXED                       |
             Status|RESOLVED                    |REOPENED

--- Comment #49 from Hin-Chung Lam <hclam at google.com>  2009-09-17 15:50:16 PDT ---
> > --- a/LayoutTests/media/video-source.html
> > +++ b/LayoutTests/media/video-source.html
> I really hate tests like this that use a document fragment and put script in
> the body for no obvious reason, so I try to clean them up when I have to change
> them anyway. It obviously isn't necessary for what you are fixing with this
> patch, but taking a few extra minutes to tidy up ugly tests like this would be
> good for everyone. Something like the following is what I would prefer
> (warning, I haven't actually tested this):

> > +++ a/LayoutTests/media/video-src-invalid-remove.html
> > --- a/LayoutTests/media/video-src-remove.html
> > --- a/LayoutTests/media/video-src-source.html

The reason why I'm coding the tests to use innerHTML instead of setting .src or
appendChild() is that these are supposed to be testing the attributes /
<source> from their text / tag form.

You'll find tests for changing .src, appendChild() already in:

I think if we are not testing src and <source> in their "src=" / <source> form
we'll be missing some test cases.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list