[Webkit-unassigned] [Bug 29115] Allow multiple read transactions to run concurrently on the same DB thread

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 17 14:35:36 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29115


Dumitru Daniliuc <dumi at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39725|                            |review?
               Flag|                            |
  Attachment #39717|0                           |1
        is obsolete|                            |
  Attachment #39717|review?                     |
               Flag|                            |




--- Comment #7 from Dumitru Daniliuc <dumi at chromium.org>  2009-09-17 14:35:34 PDT ---
Created an attachment (id=39725)
 --> (https://bugs.webkit.org/attachment.cgi?id=39725)
patch

(In reply to comment #6)
> on the new struct, add a default ctor that zero-inits
> numPendingWriteTransactions 

done.

> add a code comment that indicates the String identifies a database file

done.

> typedef HashMap<String, CoordinationInfo> CoordinationInfoMap;
> CoordinationInfoMap m_coordinationInfoMap;

done.

> 89     CoordinationInfo& cInfo = it->second;
> 
> I think webkit style would have you call this either 'info' or
> 'coordinationInfo', the cJazz has a hungarian sounds to it.

changed to 'info'.

> 57         CoordinationInfo cInfo;
> 58         cInfo.numPendingWriteTransactions = 0;
> 59         it = m_pendingTransactions.add(dbIdentifier, cInfo).first;
> 
> subtract two lines

done.

>  131             if (!cInfo.pendingTransactions.first()->isReadOnly())
>  132                 cInfo.pendingTransactions.first()->lockAcquired();
>  133             else {
>  134                 TransactionsQueue::iterator pt_it =
> cInfo.pendingTransactions.begin();
>  135                 while ((pt_it != cInfo.pendingTransactions.end()) &&
> (pt_it->get()->isReadOnly())) {
>  136                     pt_it->get()->lockAcquired();
>  137                     ++pt_it;
>  138                 }
>  139             }
> 
> Since the else clause requires braces, put them around the if clause too.

i'm not sure the webkit style allows this. at the very least, they have this
example that is correct according to the webkit guide:

if (condition)
    doSomething();
else {
    ...
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list