[Webkit-unassigned] [Bug 29291] Implement a CSS extension to adjust sub-pixel anti-aliasing for text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29291





--- Comment #5 from Beth Dakin <bdakin at apple.com>  2009-09-16 15:10:58 PDT ---
Fixed with r48441. 

This is the one change I was unable to make:

>> +            int id = primitiveValue->getIdent();
>> +            EFontSmoothing smoothing;
>> +            switch (id) {
>> +                case CSSValueAuto:
>> +                    smoothing = AutoSmooth;
>> +                    break;
>> +                case CSSValueNone:
>> +                    smoothing = NoneSmooth;
>> +                    break;
>> +                case CSSValueAntialiased:
>> +                    smoothing = Antialiased;
>> +                    break;
>> +                case CSSValueSubpixelAntialiased:
>> +                    smoothing = Subpixel_Antialiased;
>> +                    break;
>> +            }
>> +            fontDescription.setFontSmoothing(smoothing);
>
>Given the code in CSSPrimitiveValueMappings the entire block above can be
>written like this:
>
 >   fontDescription.setFontSmoothing(primitiveValue->getIdent());
>
>And not only that, it will work better than the above it also include an assert
>we omitted here. So lets do it that way!

When I tried to make this change, font smoothing was never set appropriately.
It ended up being set to the integer value of the primitive's identifier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.