[Webkit-unassigned] [Bug 29274] commit-queue should attribute committers in ChangeLog entries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 13:26:16 PDT 2009


--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-09-16 13:26:15 PDT ---
I think we've gone off track from this original bug.  We should probably pick
this discussion up on webkit-dev if you're interested in discussing the
commit-queue further.

(In reply to comment #5)
> However, if the
> contributor is not present then it would be irresponsible of me to just sit
> back and leave the builds broken, tests failing or whatever.  I could attempt
> to fix them myself.  I could roll the patch out.  

It would be possible to teach a queue to watch the bots and roll out any commit
it made if bots started failing.

> This could of course be addressed by having it spin and
> rebuild and retest if it detects another commit, but I suspect that is not how
> things work at present.

This is close to how the queue works today.  If a commit happens between when
the patch is built and when it lands, the commit will fail (due to ChangeLogs)
and the patch cq-'d.  (see bug 28316)  I have a pending change to make it spin
instead of cq- the patch.  I could easily make it more aggressive to spin if
tip of tree revision does not match the current checkout.

> You're also only testing a single platform.  Try-bots would help some here, but
> they still don't guarantee things won't be broken.

That's correct.

> This still requires someone present to take responsibility for cleaning up the
> mess.  In our current process the responsible person is the committer.  You
> haven't elaborated on who you think it is in your process.

It is true, the queue does not know how to do rollouts.  Nor do the build-bots.
  We could teach the queue how to.

> The Mac build gets broken by contributors working on Mac OS X much less
> frequently than non-Mac builds get broken.  In general the Mac build is broken
> very infrequently and is fixed very quickly, so I'm not really sure what you're
> saying here.

I think you're being overly optimistic. :)

I can't fix the behavior of committers who often break the tree and rarely look
at the bots. :)  I can fix a software program if it's breaking the tree. :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list