[Webkit-unassigned] [Bug 27514] add support for watched expressions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 09:46:43 PDT 2009


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
  Attachment #39648|review?                     |review-
               Flag|                            |

--- Comment #30 from Timothy Hatcher <timothy at hatcher.name>  2009-09-16 09:46:43 PDT ---
(From update of attachment 39648)
> +WebInspector.ObjectPropertiesSection.PropertyComparer = function(propertyA, propertyB) 

WebInspector.ObjectPropertiesSection.CompareProperties would be a better name.
PropertyComparer sounds more like a class name.

> +};

No need for the semicolon.

> +    
>  WebInspector.ObjectPropertiesSection.prototype = {

The compare function you added should come after the prototype, so the
prototype and the constructor are next to each other.

> +    updateProperties: function(properties, rootTreeElementConstructor, propertyComparer)

I think propertyComparer should be rootPropertyComparer since it is only used
for root items.

> +WebInspector.WatchExpressionsSection.NEW_WATCH_EXPRESSION = "\xA0";

This should not be all caps, it should be camelcase.

> +WebInspector.WatchExpressionsSection.PropertyComparer = function(propertyA, propertyB) 

Ditto (re: the PropertyComparer name)

> +};

No need for the semicolon.

You also need to add WatchExpressionsSidebarPane.js to the
inspector/front-end/WebKit.qrc, WebCore.gypi and WebCore.vcproj/WebCore.vcproj
for the other platforms.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list