[Webkit-unassigned] [Bug 28884] Add CreateRequestExtension to QWebPage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28884


Ariya Hidayat <ariya.hidayat at trolltech.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39517|review?(hausmann at webkit.org |review-
               Flag|)                           |




--- Comment #6 from Ariya Hidayat <ariya.hidayat at trolltech.com>  2009-09-16 06:31:25 PDT ---
(From update of attachment 39517)
> +    // Calling CreateRequestExtension allows clients who implement it to perform
> +    // operations on the QNetworkRequest::Attributes. For example, clients could
> +    // store a pointer to the frame in QNetworkRequest::User + X. This would allow
> +    // the client to associate the network request with it's originating frame.
> +    QWebPage::CreateRequestExtensionOption option;
> +    option.frame = d->m_frame;
> +    option.request = m_request;
> +    option.type = QWebPage::NavigationTypeOther;
> +
> +    QWebPage::CreateRequestExtensionReturn output;
> +    if (d->m_frame->page()->extension(QWebPage::CreateRequestExtension, &option, &output))
> +        m_request = output.request;

I am not sure about this part. Seems that we will need to construct both
structures even in the case (probably 90%) where this extension will not be
used by the client.
That seems like a waste.

Is there a way to not support the extension by default?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.