[Webkit-unassigned] [Bug 29291] Implement a CSS extension to adjust sub-pixel anti-aliasing for text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29291





--- Comment #3 from Sam Weinig <sam at webkit.org>  2009-09-15 23:02:46 PDT ---
(From update of attachment 39633)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 48402)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,66 @@
> +2009-09-15  Beth Dakin  <bdakin at apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fix for <rdar://problem/7083741> Implement a CSS extension to 
> +        adjust sub-pixel anti-aliasing for text

Please add the bugzilla bug URL here. Please also lists the tests added.

>  
> +    EFontSmoothing smoothing = fontSmoothing();
> +    if (smoothing == Antialiased) {
> +        context->setShouldAntialias(true);
> +        setShouldUseSmoothing(false);
> +    } else if (smoothing == Subpixel_Antialiased) {
> +        context->setShouldAntialias(true);
> +        setShouldUseSmoothing(true);
> +    } else if (smoothing == NoneSmooth) {
> +        context->setShouldAntialias(false);
> +        setShouldUseSmoothing(false);
> +    }
> +

Any reason not to use a switch statement here?

> +
> +    EFontSmoothing smoothing = fontSmoothing();
> +    if (smoothing == Antialiased) {
> +        graphicsContext->setShouldAntialias(true);
> +        setShouldUseSmoothing(false);
> +    } else if (smoothing == Subpixel_Antialiased) {
> +        graphicsContext->setShouldAntialias(true);
> +        setShouldUseSmoothing(true);
> +    } else if (smoothing == NoneSmooth) {
> +        graphicsContext->setShouldAntialias(false);
> +        setShouldUseSmoothing(false);
> +    }
> +

Any reason not to use a switch statement here?

>  
> +enum EFontSmoothing {
> +    AutoSmooth, NoneSmooth, Antialiased, Subpixel_Antialiased
> +};

Despite this file being filled with them, the E at the beginning of the enum
name is not necessary.  I also think the names should instead be:
  AutoSmoothing, NoSmoothing, AntialiasedSmoothing,
SubpixelAntialiasedSmoothing


The rest of the patch looks fine, but I would like for Mitz or Hyatt to look at
it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.