[Webkit-unassigned] [Bug 29274] commit-queue should attribute committers in ChangeLog entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29274





--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-09-15 22:50:50 PDT ---
(In reply to comment #3)
> The thing I don't understand with that system is who is responsible for
> cleaning up after a patch that breaks tests or builds?  In the current system
> that is the committer.  In the system you're proposing the person putting
> "commit-queue+" on the patch has no knowledge of when the patch will be landed.
>  That puts the responsibility on the person running the commit-queue.  That
> means whomever that is needs to be around and keeping an eye on things as
> patches are landed.  They're the responsible person.  The person setting the
> "commit-queue+" flag in Bugzilla is not.

It is true, the delay does warrant concern.  IIRC current policy is that the
contributer of the patch is responsible for regressions regardless of when or
by whom the patch lands.  At least that's what
http://webkit.org/coding/contributing.html seems to say.

Two imperfect answers, regarding the delay jeopardizing tree greenness:

1.  The current commit-queue guarantees that the bots for whatever OS the queue
is being run from (currently Mac Leopard) will never break.  It runs the tests,
just as the bots do, before committing.  In some future more-perfect world, it
could use try-bot results to make breaks of other platforms even less common.

2.  Rollouts.  The commit-queue pauses when the bots go red.  It checks the bot
health before every commit.  I would recommend that if the commit approver is
not around to clean up after breaks that we just roll regressions out. 
"bugzilla-tool rollout" makes rollouts rather easy.


Furthermore, if the bots are green, the commit-queue lands within 15 minutes of
cq+, so generally people are still around.

Again, none of those are perfect solutions, but they do lessen my own personal
worries about current/future usage of automated commits.

As an aside: Given how many committers currently break the mac build on a
regular basis (presumably because they don't run the layout tests locally?) I
would bet over time that even our current lame commit-queue would have a better
track record than humans as far as keeping the Leopard build green. ;)


Hopefully those thoughts are useful.  I would be interested if you have further
thoughts on the issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.