[Webkit-unassigned] [Bug 28781] Add QWebFrame::renderElement to API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 15 19:24:18 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28781





--- Comment #7 from Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>  2009-09-15 19:24:17 PDT ---
So I looked a bit more at the patch. Ariya added some code to the
DumpRenderTree to compare images, maybe that is better for the auto test, than
just comparing sizes?

The code looks fine, but im wondering about one thing. The cache optimization
is only for images right?, so that makes this comment a bit confusing

+    // fall back to full rendering if no cached image

Maybe change the other comment to

// Optimization when the render object is an image and has been cached.

Then you could leave out the other comment, or write something like

// No optimization possible, fall back to normal rendering.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list