[Webkit-unassigned] [Bug 29256] Use MemoryManager to gather platform-specific low level memory requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29256





--- Comment #7 from Yong Li <yong.li at torchmobile.com>  2009-09-15 15:59:01 PDT ---
(In reply to comment #6)
> 
> I can see some value there. But, like I said, your patch makes the problem
> you're trying to solve worse, by adding another #if without removing any.
> 

I can #define HAVE_MEMORYMANAGER 1 and make it build with MemoryManagerWin.cpp.
In this case, I can remove #if PLATFORM(WIN_OS) (allocating js block in
collector.cpp), and #if HAVE(VIRTUAL_ALLOC) in RegisterFile and
MarkStackWin.cpp. But I'm not sure if adding ../runtime/ to the INCLUDE of wtf
project file is acceptable for win32 developers.

It shouldn't be difficult to implement a MemoryMangerPosix for the ports that
uses mmap(). But I don't have a build environment for that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.