[Webkit-unassigned] [Bug 29243] Update Chromium Mac render theme files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29243


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39603|review?(dglazkov at chromium.o |review-
               Flag|rg)                         |




--- Comment #11 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-09-15 09:39:14 PDT ---
(From update of attachment 39603)
> Index: WebCore/ChangeLog
...
> +        http://crbug.com/19604

No need for the crbug reference since you mention the bugs.webkit.org link.


> Index: WebCore/platform/graphics/FloatPoint.h
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \
> +      || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

nit: indent by 8 spaces instead of 6.  normal indent is 4 spaces, so 2x that
seems appropriate for a line continuation.


> Index: WebCore/platform/graphics/FloatRect.h
...
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \
> +      || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

ditto


> Index: WebCore/platform/graphics/FloatSize.h
...
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \
> +      || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

ditto


> Index: WebCore/platform/graphics/IntRect.h
...
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \
> +      || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))
...
> +#if (PLATFORM(MAC) && !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)) \
> +      || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.