[Webkit-unassigned] [Bug 29248] [Qt] [API] Make it possible to have 'invisible' loads

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29248





--- Comment #6 from Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>  2009-09-14 18:44:42 PDT ---
To me

+    void setEnabled(bool enabled, bool clear = true);

seems a bit backward. So the WebCore setEnabled always clears history.

So maybe it would be better to separate our the clear code of setEnabled to a
clear() method (many webcore classes have clear() members)

and make setEnabled() call clear() and enable the history. 

If very little code is using the setEnabled method, you can change that to call
clear() and then setEnabled(true)

If that is not the case, I would suggest that you make another method called
setLocked() or so, and make setEnabled(true) call clear() + setLocked(false).
This might be less desirable though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.