[Webkit-unassigned] [Bug 29259] New: Local variables 'k' and 'y' in s2b() in dtoa.cpp are computed but not used

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 14 15:20:47 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29259

           Summary: Local variables 'k' and 'y' in s2b() in dtoa.cpp are
                    computed but not used
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Trivial
          Priority: P3
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: wtc at google.com
                CC: mjs at apple.com


In WebKit/JavaScriptCore/wtf/dtoa.cpp (r48248)
on the trunk, we have:

static void s2b(BigInt& b, const char* s, int nd0, int nd, uint32_t y9)
{
    int k;
    int32_t y;
    int32_t x = (nd + 8) / 9;

    for (k = 0, y = 1; x > y; y <<= 1, k++) { }
    ...

The local variables 'k' and 'y' are not used
after the for loop, so the variables 'k' and
'y' and the for loop can be deleted.

This is a cleanup of r43457.

Also, the macro Kmax is defined but not used:

#define Kmax 15

That definition can be deleted.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list