[Webkit-unassigned] [Bug 28819] Heap profiler: showing retainers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28819


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver at apple.com,
                   |                            |rik at webkit.org




--- Comment #1 from Timothy Hatcher <timothy at hatcher.name>  2009-09-14 13:39:02 PDT ---
I like the idea of this and think it would be really useful. I am a little
confused by the UI.

I think instead of double click, it should just be a normal selection and
whatever is selected will show the retainers. Maybe a double click would still
open the sidebar, but a row selection would still be in place to show where you
came from.

Seeing the sizes in the tree with the retainers under it was confusing to me.
It wasn't clear each size represented an instance of the bar object. I think we
need a clearer way to show that (and have the size too.)

Here is what Instruments shows:

http://i607.photobucket.com/albums/tt158/steve5566/Picture3.png

Obvious they can show you a address for each object/malloc. So it is easy for
them. With JS we don't have anything like that, that would be meaningful to the
site developer…

Even just a "baz 1", "baz 2", "baz 3" would be fine. As long as the numbers
were consistent between profiles, it would be really useful to see what objects
still are alive, and what might be new (but happen to have the same size and an
older object of the same class.)

What might make the UI clearer still is to not use a hierarchy in the sidebar,
but split it vertically into two parts. Instances at the top and retainers at
the bottom for the selected instance. But maybe that is too much, and once the
sizes are not the top level items and it says "baz 1" it will be good as a
hierarchy.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.