[Webkit-unassigned] [Bug 28908] Support conditional breakpoints in the frontend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28908





--- Comment #9 from apavlov at chromium.org  2009-09-14 12:27:42 PDT ---
(In reply to comment #7)
> (From update of attachment 39545 [details])
> > +WebInspector.Popup.prototype =
> > +{
> 
> The brace for prototypes should be next to the equals on one line to match the
> other classes.
Sorry, I confused them a bit.

> > +        var popupDoc = this.element.contentDocument;
> 
> We don't abbreviate Document as Doc in WebKit. This should be popupDocument.
Oops, fixed.

> > +.breakpoint-list a.breakpoint-has-condition::after {
> > +    content: " (?)";
> > +}
> 
> I now see what this is for. I don't think this is the best way to show
> conditional break points. I think we should show the condition somehow in the
> Breakpoints pane. (This also isn't localizable in CSS.)
Yes, L10N was one of my concerns about this solution, too. I considered several
approaches, but no consistent decision yet.

> Remove this for now and file a bug about showing them in the Breakpoints pane.
Filed https://bugs.webkit.org/show_bug.cgi?id=29251 - let's discuss it there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.