[Webkit-unassigned] [Bug 29245] elementFromPoint() and caretRangeFromPoint() work only in initial containing block

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29245


Andrew Richards <randrew at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39549|                            |review?
               Flag|                            |




--- Comment #1 from Andrew Richards <randrew at gmail.com>  2009-09-14 10:00:30 PDT ---
Created an attachment (id=39549)
 --> (https://bugs.webkit.org/attachment.cgi?id=39549)
Patch to use different bounds checking and extend tests

I haven't worked with WebKit before, but after reading a bit I believe the
bounds checking in Document::caretRangeFromPoint() and elementFromPoint() is
mistakenly using boundsRect() from a FrameView to find if the point is in the
viewport. This was causing it to return null if you called it with a point that
had to be scrolled to. I changed it to use visibleContentRect() instead, which
seems to have fixed it.

I also extended the tests to include checking for this issue. There are now hit
tests which require a page to be scrolled before their points are visible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.