[Webkit-unassigned] [Bug 28908] Support conditional breakpoints in the frontend

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 14 09:52:23 PDT 2009


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
  Attachment #39545|review?                     |review-
               Flag|                            |

--- Comment #7 from Timothy Hatcher <timothy at hatcher.name>  2009-09-14 09:52:23 PDT ---
(From update of attachment 39545)
> +WebInspector.Popup.prototype =
> +{

The brace for prototypes should be next to the equals on one line to match the
other classes.

> +        var popupDoc = this.element.contentDocument;

We don't abbreviate Document as Doc in WebKit. This should be popupDocument.

> +.breakpoint-list a.breakpoint-has-condition::after {
> +    content: " (?)";
> +}

I now see what this is for. I don't think this is the best way to show
conditional break points. I think we should show the condition somehow in the
Breakpoints pane. (This also isn't localizable in CSS.)

Remove this for now and file a bug about showing them in the Breakpoints pane.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list