[Webkit-unassigned] [Bug 29190] commit-log-editor should move common prefixes to the top of the commit log

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 14 09:01:35 PDT 2009


--- Comment #2 from Adam Roben (aroben) <aroben at apple.com>  2009-09-14 09:01:35 PDT ---
(In reply to comment #1)
> (From update of attachment 39445 [details])
> > +    foreach my $key (keys %{$hashOfStrings}) {
> > +        $hashOfStrings->{$key} = substr($hashOfStrings->{$key}, $lastDoubleNewline);
> Don't you want to use ($lastDoubleNewline + 2) here as well?

The current behavior is what we want. The leading double newline that's left on
each ChangeLog entry ends up right after the label for that ChangeLog, like
"WebCore:\n\nUnique part of the entry".

But even though this is the behavior we want, it does seem a bit subtle. It
would probably be better to strip the leading double newline from each entry,
then explicitly add the double newline after each label.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list