[Webkit-unassigned] [Bug 26342] Absolutely positioned HTML element within foreignObject of absolutely positioned SVG crashes Safari

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26342


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39535|review?                     |review-
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2009-09-14 07:50:45 PDT ---
(From update of attachment 39535)
Thanks for tackling this!

> +        This is to fix the crash reported with
> +        https://bugs.webkit.org/show_bug.cgi?id=26342
> +
> +        Test case at : http://www.barhams.info/webkit/crash.xml

In the WebKit project we require regression tests for any bug fix. So this fix
needs to include a test for the LayoutTests directory that demonstrates the
crash and that it is fixed.

>      if (!o || !o->isRenderBlock())
> -        return 0; // Probably doesn't happen any more, but leave just in case. -dwh
> +        return document()->renderView(); // return the render view of the document, which is the top level containner

This comment doesn't indicate why it is correct and acceptable to return
container.

Typo here: "containner"

WebKit style uses sentence style comments, with capital letters and periods.

> -    ASSERT(useTransforms); // mapping a point through SVG w/o respecting trasnforms is useless.
> +//    ASSERT(useTransforms); // mapping a point through SVG w/o respecting trasnforms is useless.

We don't include commented-out code in WebKit. If the assertion is wrong it
should be removed, not commented out. Further, you don't explain why you are
removing this assertion.

> -    ASSERT(useTransforms); // mapping a point through SVG w/o respecting trasnforms is useless.
> +//    ASSERT(useTransforms); // mapping a point through SVG w/o respecting trasnforms is useless.

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.