[Webkit-unassigned] [Bug 29196] wx port is missing several filesystem functions in FileSystemWx.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29196


Kevin Ollivier <kevino at theolliviers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever Confirmed|0                           |1
                 CC|                            |kevino at theolliviers.com
             Status|UNCONFIRMED                 |NEW




--- Comment #3 from Kevin Ollivier <kevino at theolliviers.com>  2009-09-13 17:56:05 PDT ---
Landed in r48344, thanks!(In reply to comment #2)
> (From update of attachment 39454 [details])
> This looks fine.  Except do you really want to use 0777?
>  76     return wxFileName::Mkdir(path, 0777, wxPATH_MKDIR_FULL);
> 
> Wouldn't you want to respect the user's umask?  Or at least restrict these to
> rwx for the user?

Sorry, didn't notice this comment somehow before landing the change. (r48344,
BTW) After checking into it, I do see that the POSIX and GTK implementations do
set umask to rwx for the user. Whether this is the right behavior for this API
or not (vs. respecting the user's umask), I don't know, but it would seem that
we run less risk of having unpredictable behavior by doing the same thing as
other platforms. I'll leave this ticket open and work up a patch to change it
if Kevin W. doesn't beat me to it. ;)

Thanks for catching this!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.