[Webkit-unassigned] [Bug 29204] Compile KeyframeList.cpp and AnimationBase.cpp in winscw compiler.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29204





--- Comment #4 from Yongjun Zhang <yongjun.zhang at nokia.com>  2009-09-11 20:57:50 PDT ---
(In reply to comment #3)
> (From update of attachment 39472 [details])

Thanks a lot for the comment, Eric.

> Why are these changes needed? And why are we supporting this broken compiler...

Winscw compiler (based on Codewarrior) is used in building apps running in S60
emulator, so far that is the only available emulator compiler for us :-(

> ;)  The number of fixes needed to make winscw work seems to be growing without
> bound.

We fully understand the concern; and we tried hard to make sure the changes are
minimum and really necessary. Good news is all the winscw patches are submitted
for review and looks like there won't be any further patches for this issue any
more.

> r-.  We need more explanation for each of these (seemingly arbitrary) changes,
> and ideally links to compiler bugs you've filed with the winscw folks.

There is a bug for it in winscw compiler bugzilla
(https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812). It is
essentially the same issue as https://bugs.webkit.org/show_bug?id=28054 except
it is caused by ref(), not deref().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.