[Webkit-unassigned] [Bug 29121] XMLHttpRequest::getAllResponseHeaders throws INVALID_STATE_ERR when called in state HEADERS_RECEIVED

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 16:00:54 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29121





--- Comment #18 from Alexey Proskuryakov <ap at webkit.org>  2009-09-11 16:00:52 PDT ---
(In reply to comment #17)
> The text your are mentioning is intentionally left that way. If the test is run
> interactively, that is in a regular browser, not with DumpRenderTree the list
> of headers and the the value of the header respectively are still displayed.

I like that the headers are fully dumped when the test is run in Safari, it can
be very helpful.

But this text is confusing nonetheless. There is no reason to leave it in this
state - it's easy to have different output for DRT. In fact, we often do the
following for DRT-only tests:

if (!window.layoutTestController)
    document.write("<p>This test only works in run-webkit-tests</p>");

Since this code has a long history of changes, it is particularly important not
to leave any confusing comments around it.

> I have read the discussion that you mentioned. I believe that my change which
> leads to an exception not being thrown, not to extra exceptions being thrown,

Yes, that's correct. I just wanted to give some additional context, as it
appears that at least some browsers' behavior has changed since 2007.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list