[Webkit-unassigned] [Bug 28851] Emit last progress notification before calling dispatchDidFinishLoad

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 09:34:03 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28851





--- Comment #5 from Brady Eidson <beidson at apple.com>  2009-09-11 09:34:03 PDT ---
The concept is fine.
If all layout tests continue to pass on all platforms, then the patch is fine.

It makes me nervous that we've had this behavior forever and are changing it
now.

But we need tests.  That we've had this bizarre behavior forever and no layout
test covered it is something that needs to change.

DRT already listens to didFinishLoadForFrame, but can definitely be augmented
to listen for the progress notifications also.

Sometimes the DRT changes to test a patch are 20 times bigger than the patch
itself - This might be one of those times...  ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list