[Webkit-unassigned] [Bug 29185] [Qt] QWebGraphicsItem should check for null QWebPage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29185





--- Comment #3 from Jakub Wieczorek <faw217 at gmail.com>  2009-09-11 09:28:50 PDT ---
(In reply to comment #2)
> jakub, looks good overall ... just one question: in comment 
> https://bugs.webkit.org/show_bug.cgi?id=28862#c14 simon suggested to not use
> page() (maybe to avoid a unnecessary method call overhead), but d->page ...
> maybe we should respect that ?
> 
> ps: although i agree w/ your idea since page() willalways return a non-null
> pointer

I agree with the comment as far as it concerns functions that should silently
return when the page is null. But most of them should just create a default
page when they are called. That's also how QWebView works and I believe that
QWebGraphicsItem should be symmetrical to that. Otherwise, you would never be
able to load an url because the page would always be null.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.