[Webkit-unassigned] [Bug 29152] [v8] inline WebCore::v8String

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29152





--- Comment #5 from anton muhin <antonm at chromium.org>  2009-09-11 05:49:21 PDT ---
(In reply to comment #3)
> Looks like this patch does not have full paths in it.  Make sure you use
> svn-create-patch to create your patches.  Although it's possible you're hitting
> bug 29112.
> 
> can't find file to patch at input line 5
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |Index: bindings/v8/V8Binding.cpp
> |===================================================================
> |--- bindings/v8/V8Binding.cpp    (revision 48239)
> |+++ bindings/v8/V8Binding.cpp    (working copy)
> --------------------------
> No file to patch.  Skipping patch.
> 1 out of 1 hunk ignored
> can't find file to patch at input line 5
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |Index: bindings/v8/V8Binding.h
> |===================================================================
> |--- bindings/v8/V8Binding.h    (revision 48239)
> |+++ bindings/v8/V8Binding.h    (working copy)
> --------------------------
> No file to patch.  Skipping patch.
> 2 out of 2 hunks ignored

Eric, I do use svn-create-patch (in Chromium tree, on MacOS, with WebKitTools,
separate WebKit checkout) and that's exactly the way it creates patches.  I
raised this issue one, but currently don't have time to fix it myself.

This patch was produced with plain svn diff and, hopefully, has correct paths.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.