[Webkit-unassigned] [Bug 29077] [v8] Share persistent context handles between events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29077





--- Comment #12 from Christian Plesner Hansen <christian.plesner.hansen at gmail.com>  2009-09-11 02:28:04 PDT ---
> But you see that the lifetime of the handle has changed right?  We need to
> think carefully and make sure that the new lifetime is ok for the event
> listeners.  The key point is that the event listeners won't fire when they
> ought not to fire.  We have some amount of test coverage for this, but it's not
> complete.
> 
> Maybe we're ok because V8Proxy explicitly Disposes / Clears the shared context
> when it would have dropped its strong handle before?

The handle is disposed by the proxy at the same time now as before.  What is
different is that before event would hang on to the context from the V8Proxy
had disposed its handle and until the next gc (which, incidentally, made event
behavior non-deterministic) whereas now events lose access to the context
immediately.  I would expect that to be 

> The whole thing is super confusing though.  If you're in the main world, it
> just so happens that the shared context is a strong reference to the context,
> but when you're in an isolated world, the shared handle is weak.  All the
> clients of V8Proxy::context(Frame*) now have to be prepared to deal with either
> case.
> 
> Maybe we're ok because these clients already have to worry about this issue?

The handle returned here will behave exactly the same as before since it's
returned directly from the owner who has the same behavior as before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.