[Webkit-unassigned] [Bug 28327] Media layout tests should have a way to provide test files in different formats

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28327





--- Comment #36 from Hin-Chung Lam <hclam at google.com>  2009-09-11 00:25:36 PDT ---
(In reply to comment #34)
> (From update of attachment 39405 [details])
> > -                // controller should still be visible after a second
> > -                setTimeout(function() { layoutTestController.notifyDone(); } , 1000);
> > -            }
> > +                setTimeout(function() {
> > +                    if (window.layoutTestController)
> > +                        layoutTestController.notifyDone();
> > +                } , 1000);
> 
> Is there any reason to remove the comment about what the 1 second timeout is
> for?
> 
> r=me

This comment is not relavent any more since it's refering to that using
layoutTestController is safe given that it is within an if statement that
checks layoutTestController. In the new code I check for layoutTestController
explicitly within the timeout function so the statement is not accurate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.