[Webkit-unassigned] [Bug 29122] Use PLATFORM(ARM_THUMB2) instead of PLATFORM_ARM_ARCH(7)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29122





--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2009-09-11 00:08:11 PDT ---
I'm not really comfortable with this patch, since it seems to me to give a
misleading impression.  I think that a new programmer to JSC could easily be
lead to assume that PLATFORM_ARM, PLATFORM_ARM_THUMB2, PLATFORM_X86, and
PLATFORM_X86_64 are all independent and equivalent in behavior.  A programmer
could very easily make the mistake of assuming that code wrapped in
PLATFORM(ARM) would not be compiled on a PLATFORM(ARM_THUMB2) build.  This is
not the case – both platforms are ARM platforms, and both define that macro.

I think that to aid clarity in the code and make it more explicit what is going
on we should be going the other way – making all ifdefs that check for either
ARM or ARMv7 (but not both) use either:

    PLATFORM(ARM) && PLATFORM_ARM_ARCH(7)
or
    PLATFORM(ARM) && !PLATFORM_ARM_ARCH(7)

Such that we are very explicit, rather than relying on the ordering of ifdefs,
which may be fragile.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.