[Webkit-unassigned] [Bug 29165] Remove duplicated WK_{u, l}cfirst subs from CodeGeneratorV8.pm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 17:31:16 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29165


Cameron McCormack <cam at mcc.id.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39399|                            |review?
               Flag|                            |




--- Comment #1 from Cameron McCormack <cam at mcc.id.au>  2009-09-10 17:31:16 PDT ---
Created an attachment (id=39399)
 --> (https://bugs.webkit.org/attachment.cgi?id=39399)
Patch v1

I note that the WK_lcfirst in CodeGenerator.pm is different from the one in
CodeGeneratorV8.pm.  The only case that CodeGeneratorV8 calls WK_lcfirst for is
the "URL" attribute on Document (and a couple of other interfaces), so there
should be no change in output.  I inspected the output of running
generate-bindings.pl on Document visually, but didn't build anything to test (I
guess I'd need to check out Chromium to do that).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list