[Webkit-unassigned] [Bug 29161] Implement default media UI for mac chromium.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 17:02:54 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29161


Albert J. Wong <ajwong at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39393|                            |review?
               Flag|                            |




--- Comment #1 from Albert J. Wong <ajwong at chromium.org>  2009-09-10 17:02:54 PDT ---
Created an attachment (id=39393)
 --> (https://bugs.webkit.org/attachment.cgi?id=39393)
Reimplement default media UI for Mac Chromium to match the style

of the Windows and Linux versions.  Also breaks the dependency
on the internal wk* functions that were previously used to
render the media controller widgets.
https://bugs.webkit.org/show_bug.cgi?id=29161

Patch by Albert J. Wong <ajwong at chromium.org> on 2009-09-10
Reviewed by NOBODY (OOPS!).

No media layout tests are currently enabled in Mac Chromium, so
nothing needs rebaselineing, etc.

* css/mediaControlsChromium.css:
* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(WebCore::mediaElementParent):
(WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet):
(WebCore::mediaSliderThumbImage):
(WebCore::mediaVolumeSliderThumbImage):
(WebCore::RenderThemeChromiumMac::paintSliderTrack):
(WebCore::RenderThemeChromiumMac::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumMac::paintMediaButtonInternal):
(WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
(WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
(WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
(WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
(WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
---
 5 files changed, 256 insertions(+), 99 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list