[Webkit-unassigned] [Bug 28982] Basic MathML Rendering Support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28982


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39223|review?                     |review-
               Flag|                            |




--- Comment #6 from Dave Hyatt <hyatt at apple.com>  2009-09-10 15:58:22 PDT ---
(From update of attachment 39223)
You've got a lot of style violations still, so let's get that taken care of.

Please fix the CSS file to be more readable:

selector {
   property/value pairs (one per line);
}

We no longer indent class declarations in header files (many of the files
violate this still).  They should just be flush left, e.g.,:

namespace WebCore {

class MathMLElement ....

}

Omit braces when you only have a single line for else statements or for stuff
inside a loop, e.g.,

else if (localName()=="mfrac") {
          object = new (arena) RenderFraction(this);
      } 

^^^^ That is wrong.  Just drop the braces.

#endifs traditionally say what they are closing, e.g.,

#endif // MathMLElement_h

#endif // namespace WebCore

Make sure to have spaces in comparators and mathematical expressions, e.g.,:

if (localName()=="mfenced")

should be:

if (localName() == "mfenced")

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.