[Webkit-unassigned] [Bug 28806] [Qt] Make the WebInspector available as a widget class.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28806


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hausmann at webkit.org




--- Comment #8 from Simon Hausmann <hausmann at webkit.org>  2009-09-10 13:35:40 PDT ---
(In reply to comment #7)
> Created an attachment (id=39347)
 --> (https://bugs.webkit.org/attachment.cgi?id=39347) [details]
> Changes v0.5
> 
> Stuff that may be worth noting about this patch relatively to v0.4:
> 
> The inspectedElement argument to the webInspectorTriggered signal is currently,
> as I saw, always the same as the focused element in the inspector.
> However this is mostly luck since we can't create QWebElements out of non-html
> nodes and the inspector also seems to focus on the enclosing Html element.
> 
> For example if we right click on a text node in the page, the hittestresult
> will contain a WebCore::Text node.
> - This patch will walk the parents until a QWebElement can be created from the
> hittestresult's parents before giving it to the signal.
> - The web inspector will select the surrounding <font> element, however I would
> not expect this behavior since the text node is available for selection and it
> may change in the future.
> 
> I documented in the signal that the inspectedElement argument is not garanteed
> to be the same.
> There is also the possibility of not giving this argument in the signal, since
> the user may expect the same value and it may feel unreliable.
> 
> Please tell me what you think.

The patch looks good to me. I'd like to r+ it, but after trying the patch I
just noticed that "inspect element" from the context menu in the QtLauncher
doesn't seem to work for me. It comes up in the splitter, but it doesn't show
the inspected element or anything else.

Can you reproduce that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.