[Webkit-unassigned] [Bug 25930] Mismatched free

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25930


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39353|review?                     |review+
               Flag|                            |




--- Comment #14 from Darin Adler <darin at apple.com>  2009-09-10 10:22:02 PDT ---
(From update of attachment 39353)
> -        // We want to free the memory (which was allocated with new), but we
> +        // We want to free the memory (which was allocated with fastNew), but we
>          // don't want the destructor to run since it will affect the copy
> -        // we've just made. In theory this is undefined, but operator delete
> -        // is only defined taking a void*, so in practice it should be ok.
> -        delete reinterpret_cast<char*>(selectorVector[i]);
> +        // we've just made. We use fastDeleteSkippingDestructor function, because
> +        // that is releasing without destructor call.
> +        fastDeleteSkippingDestructor(selectorVector[i]);

I think we should leave out the last sentence of the comment here. The name of
the function is clear enough and matches the comment in an obvious way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.