[Webkit-unassigned] [Bug 29127] New: commit-log-editor: Abort commit on unchanged commit messages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29127

           Summary: commit-log-editor: Abort commit on unchanged commit
                    messages
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jpetsovits at rim.com


Normally, when I submit an empty commit message to my VCS, it would abort (or
at least ask me to abort) the commit.
When commit-log-editor runs, it prefills the message, thus it's not empty
anymore, thus the commit doesn't abort if I choose to back off and leave it as
is. That's kinda annoying.

The patch below makes commit-log-editor keep a backup of the original file
(that is passed to $EDITOR) and after $EDITOR exits, compares the user's one
with the original one so that it can abort when nothing changed.

Improves commit workflows considerably! Please review, thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.