[Webkit-unassigned] [Bug 29126] Play/pause button in <video> controls shows the wrong image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29126





--- Comment #3 from Adam Roben (aroben) <aroben at apple.com>  2009-09-10 09:04:16 PDT ---
Shoot, I missed that you had made comments! Sorry about that.

(In reply to comment #1)
> (From update of attachment 39351 [details])
> > +        No test possible.
> 
> The existing pixel tests will check this as a side effect - once you update the
> results ;-)

We don't run pixel tests on Windows, nor do we have any expected results for
pixel tests on Windows. Since this is a Windows-specific change, I don't think
there's anything I can do here. Am I missing something?

> > -                bool currentlyPlaying = btn->displayType() == MediaPlayButton;
> > -                paintThemePart(currentlyPlaying ? SafariTheme::MediaPauseButtonPart : SafariTheme::MediaPlayButtonPart, paintInfo.context->platformContext(), r, NSRegularControlSize, determineState(o));
> > +                bool canPlay = btn->displayType() == MediaPlayButton;
> > +                paintThemePart(canPlay ? SafariTheme::MediaPlayButtonPart : SafariTheme::MediaPauseButtonPart, paintInfo.context->platformContext(), r, NSRegularControlSize, determineState(o));
> 
> "canPlay" can be slightly misleading because the movie may not have enough
> media buffered to begin playback immediately, but I may be too pedantic.

I took the "canPlay" terminology from
MediaControlPlayButtonElement::updateDisplayType
<http://trac.webkit.org/browser/trunk/WebCore/rendering/MediaControlElements.cpp?rev=47774#L473>.
Is the terminology inaccurate there, too?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.