[Webkit-unassigned] [Bug 29126] Play/pause button in <video> controls shows the wrong image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29126


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39351|review?                     |review+
               Flag|                            |




--- Comment #1 from Eric Carlson <eric.carlson at apple.com>  2009-09-10 08:53:32 PDT ---
(From update of attachment 39351)
> +        No test possible.

The existing pixel tests will check this as a side effect - once you update the
results ;-)


> -                bool currentlyPlaying = btn->displayType() == MediaPlayButton;
> -                paintThemePart(currentlyPlaying ? SafariTheme::MediaPauseButtonPart : SafariTheme::MediaPlayButtonPart, paintInfo.context->platformContext(), r, NSRegularControlSize, determineState(o));
> +                bool canPlay = btn->displayType() == MediaPlayButton;
> +                paintThemePart(canPlay ? SafariTheme::MediaPlayButtonPart : SafariTheme::MediaPauseButtonPart, paintInfo.context->platformContext(), r, NSRegularControlSize, determineState(o));

"canPlay" can be slightly misleading because the movie may not have enough
media buffered to begin playback immediately, but I may be too pedantic.

r=me if you update the pixel test results at some point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.