[Webkit-unassigned] [Bug 25930] Mismatched free

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 07:04:30 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25930


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39346|review+                     |review-
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2009-09-10 07:04:29 PDT ---
(From update of attachment 39346)
> Index: JavaScriptCore/wtf/HashSet.h
> ===================================================================
> --- JavaScriptCore/wtf/HashSet.h	(revision 47860)
> +++ JavaScriptCore/wtf/HashSet.h	(working copy)
> @@ -91,7 +91,7 @@ namespace WTF {
>  
>      private:
>          friend void deleteAllValues<>(const HashSet&);
> -
> +    public:
>          HashTableType m_impl;
>      };

Wait, this isn't right!? m_impl should not be public! The fastDeleteAllValues
function needs to be a friend just as deleteAllValues is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list