[Webkit-unassigned] [Bug 23262] Dual lines in css2.1 layout tests do not match:

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23262





--- Comment #12 from Shinichiro Hamaji <hamaji at chromium.org>  2009-09-10 02:20:42 PDT ---
> OK.  Since this is so hard to test, I should ask:  you tested to make sure your
> tests failed before your change?

Yes. If you want, please check the following URLs:

http://shinh.skr.jp/t/t1204-increment-00-c-o.html
http://shinh.skr.jp/t/t1204-increment-01-c-o.html

You should see two lines and these texts are different.

> Also this will cause failures on the bots because results for other platforms
> are missing.  Someone will have to commit this manually and be around to commit
> the results for the other platforms too.

Yeah, I'm sorry about this... Are there any tools which are similar to the
Chromium's rebaseline tool? I don't know how it is doing the trick actually.
But, I think it sends some layout tests to the buildbot server, the server runs
the layout tests with recent builds, and the server returns the results. We can
check the result images and if it looks OK, we can commit the results. This is
quite handy because we don't need to have many platforms we are supporting.

> The tests need some comments to explain the tricky bits.  Like the fact that
> they use a timeout and that they are not dump as text because the bug doesn't
> trigger in those cases.

I see. I added some comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.