[Webkit-unassigned] [Bug 28038] WebSocket API implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28038





--- Comment #45 from Fumitoshi Ukai <ukai at chromium.org>  2009-09-09 20:07:49 PDT ---
(In reply to comment #41)
> > We should not check this in until we have build implementations for all
> > platforms, since WEB_SOCKETS is enabled on all platforms.
> 
> I'm confused - why is it enabled on all platforms? If that's the case, then all
> build systems need to be updated. The intention was to postpone enabling it on
> other platforms.
> 
> My guess is that Windows build was broken because files were added in
> DerivedSources.cpp. It's fine to update the Windows project file, but I'm
> worried whether it was done for the right reasons now, and I'm worried if other
> platforms are still affected.
> 
> Maybe some platforms also cannot find non-generated include files from the new
> websockets directory? In this case, at least search paths will need to be
> updated for all of them.
> 
> +        Fix windows build to r48121, that was reverted by r48137.
> 
> Since the patch was already reverted, this is not a build fix any more. This
> line can be just removed from all ChangeLogs.

Fixed ChangeLogs.
Is there anything I need to fix more?(In reply to comment #41)
> > We should not check this in until we have build implementations for all
> > platforms, since WEB_SOCKETS is enabled on all platforms.
> 
> I'm confused - why is it enabled on all platforms? If that's the case, then all
> build systems need to be updated. The intention was to postpone enabling it on
> other platforms.
> 
> My guess is that Windows build was broken because files were added in
> DerivedSources.cpp. It's fine to update the Windows project file, but I'm
> worried whether it was done for the right reasons now, and I'm worried if other
> platforms are still affected.
> 
> Maybe some platforms also cannot find non-generated include files from the new
> websockets directory? In this case, at least search paths will need to be
> updated for all of them.
> 
> +        Fix windows build to r48121, that was reverted by r48137.
> 
> Since the patch was already reverted, this is not a build fix any more. This
> line can be just removed from all ChangeLogs.

Fixed ChangeLogs.
Is there anything I need to fix?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.