[Webkit-unassigned] [Bug 29065] svn-unapply doesn't revert directories correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29065


Cameron McCormack <cam at mcc.id.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39309|                            |review?
               Flag|                            |
  Attachment #39242|0                           |1
        is obsolete|                            |




--- Comment #4 from Cameron McCormack <cam at mcc.id.au>  2009-09-09 16:34:30 PDT ---
Created an attachment (id=39309)
 --> (https://bugs.webkit.org/attachment.cgi?id=39309)
Patch v2

(In reply to comment #2)
> it seems this repeated regexp really should be in a function, or at least as a
> constant.

Done.  Note also I fixed a small bug -- the second s/// I added was being
applied to $_ when it should have been applied to $svnStatus.

> Also, I think perl is slightly more readable when you make use of $_ explicit,
> so I prefer the old code.

I'd argue that leaving off the "$_ =~" is more idiomatic Perl, but OK, done. 
Perhaps if I'd included it I would've picked up the above bug first time
around. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.