[Webkit-unassigned] [Bug 28862] [Qt][API] Add a new QGraphicsWidget based version of the "QWebView"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28862


Jakub Wieczorek <faw217 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |faw217 at gmail.com




--- Comment #41 from Jakub Wieczorek <faw217 at gmail.com>  2009-09-09 13:50:54 PDT ---
+/*!
+    \property QWebGraphicsItem::zoomFactor
+    \since 4.5
+    \brief the zoom factor for the view
+*/

The \since tag should be removed.

+/*!
+    Returns a pointer to the view's history of navigated web pages.
+
+    It is equivalent to
+
+    \snippet webkitsnippets/qtwebkit_qwebview_snippet.cpp 0

The snippet is for QWebView, should be removed or we should have another one
based on QWebGraphicsItem.

+QWebHistory* QWebGraphicsItem::history() const
+{
+    return d->page->history();
+}

A bunch of functions such as settings(), load(), history() would crash when the
page is null, they should either construct a QWebPage or silently return. An
autotest would catch it, I can help you out with that. :)

Very nice, Kenneth. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.