[Webkit-unassigned] [Bug 28422] Linking fails with "relocation R_X86_64_PC32 against symbol `cti_vm_throw'"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28422





--- Comment #12 from Gavin Barraclough <barraclough at apple.com>  2009-09-09 13:40:01 PDT ---
(From update of attachment 38607)
This patch seems sensible to me, seems reasonable to use plt-indirect calls on
linux.  Doesn't seem to be a relevant issue to Mac.

My one concern would be the name, SYMBOL_STRING_INTERNAL, which doesn't seem to
be accurately descriptive to me.  The strings formed by this macro seem
specific to the use case – I don't believe foo at plt syntax is commonly used
outside of use in a call?  For symbols internal to a compilation module, it is
just a question of omitting the .globl directive?  I'd suggest renaming the
macro to something like SYMBOL_FOR_CALL would probably be clearer, but I don't
know linux x86-64 asm that well, so perhaps I'm wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.