[Webkit-unassigned] [Bug 28862] [Qt][API] Add a new QGraphicsWidget based version of the "QWebView"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28862


Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #38 from Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>  2009-09-09 13:37:52 PDT ---
Landed in 48219.

> Please also re-implement QGraphicsItem::sceneEvent() as well as
> QObject::event(), similar to QWebView.
> That allows fixing event-related bugs in patch releases without the need to
> re-implement an existing
> virtual function, which by adding a new symbol cannot be done in patch releases
> otherwise.

OK, will do it a follow up.

> > +++ b/WebKit/qt/QGVLauncher/main.cpp
> 
> This file has a fewcoding style violations in them (* placement for example).
> Please fix before landing.

Fixed.

> > +    // Only do implicit paints for QWebView's
> > +    if (QWebView* view = qobject_cast<QWebView*>(m_webPage->view()))

> I really hope that we can eliminate these casts in the future, for example by
> making
> QWebGraphicsItem not call setView() but instead simply keep the widget from the
> events
> around but not using it in the above methods.
> 

With the QWebPageClient we will be able to do so.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.