[Webkit-unassigned] [Bug 29091] commit-queue hangs if a builder has never built
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 9 11:36:38 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=29091
David Levin <levin at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #39276|review? |review+, commit-queue-
Flag| |
--- Comment #2 from David Levin <levin at chromium.org> 2009-09-09 11:36:37 PDT ---
(From update of attachment 39276)
r=me if there is a good answer to my question below.
> diff --git a/WebKitTools/Scripts/modules/buildbot.py b/WebKitTools/Scripts/modules/buildbot.py
> + if not status_link:
> + # We failed to find a link in the first cell, just give up.
> + # This can happen if a builder is just-added, the first cell will just be "no build"
> + return builder
Are other parts of the code robust to 'built_revision', 'is_green', 'build_url'
not being in builder?
> diff --git a/WebKitTools/Scripts/modules/buildbot_unittest.py b/WebKitTools/Scripts/modules/buildbot_unittest.py
> + <td align="center" class="Activity building">building<br />< 1 min</td>
< 1 min ?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list