[Webkit-unassigned] [Bug 28914] Add a test for iframe shims and windowed plugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28914


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39004|review?                     |review-
               Flag|                            |




--- Comment #12 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-09-09 10:45:58 PDT ---
(From update of attachment 39004)
Almost there!

> +                if (!tags.pluginNorelative) {
> +                    parentdiv.style.position = 'relative';
> +                }

No braces around one-liners.

> +
> +                if (pluginDivZ) {
> +                    parentdiv.style.zIndex = pluginDivZ;
> +                }

Ditto.

> +                root.appendChild(parentdiv);
> +            } else {
> +                if (!tags.pluginNorelative) {
> +                    pd.style.position = 'relative';

Ditto.


> +            if (overlayDivZIframe) {
> +                id.style.zIndex = overlayDivZIframe;

Ditto.


> +            if (overlayDivZOverlay) {
> +            od.style.zIndex = overlayDivZOverlay;
> +            }

No braces + indent.

> +                if (overlayDivZOverlay) {
> +                    parentdiv.style.zIndex = overlayDivZOverlay;
> +                }

No braces.

> +        for (k in expectedClicks) {
> +            if (expectedClicks[k] && !clicks[k]) {
> +                waitingForMoreClicks = true;
> +	    } else if (!expectedClicks[k] && clicks[k]) {

Indent issue here. Should be one more to indent w/if?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.