[Webkit-unassigned] [Bug 29079] ARM compiler does not understand GCC visibility attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29079





--- Comment #6 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2009-09-09 10:28:32 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (From update of attachment 39263 [details] [details] [details])
> > > Is it really the ARM issue that makes this not support visibility? Or is it
> > > version-specific? r=me, but I suspect this is not as good a condition as it
> > > could be.
> > 
> > Darin, thanks for the review. 
> > 
> > This is an issue with the compiler syntax. ARM compiler does support visibility
> > declarations (which is different from GCC so the extra test is needed). For now
> > we do not really need the visibility decaration for the ARM ports now so my
> > patch leaves the JS_EXPORT empty for ARM.
> 
> Who is "we"? Boston Team? Will this affect compiling Qt 4.6 for ARM in general?

Kenneth, sorry for the vague use of words. 

The change only has an impact for the ARMCC compiler (also known as ADS or
RVCT). As far as I know only the Symbian port using the RVCT compiler, although
in theory other ports/platforms might be able to use it as well.

This change has no impact on those ARM ports (including the QtWebKit ARM ports)
that are using GCC.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.